About HTTPClientSession creates persistent connection

[kevin00000000ex]

I create a persistent connection to a http server with HTTPClientSession object. When I receive the http response the isteam state change to badbit and then I call the HTTPpClientSession.reset() function to close current http connection.
I send the next http request with a new connection.But when I receive the http response I find I have received the residual http response correspond to the last request and the HTTPClientSession.receiveResponse ()function throw a exception, the exception.what() is "Malformed message: No HTTP response header".
I search the reason and find the residual http response is in the HTTPSession._pBuffer member variable.

So my question is why not emptied the _pBuffer through HTTPClientSession.reset() function in POCO completion. What should I do to solve the question?

[alex]

So my question is why not emptied the _pBuffer through HTTPClientSession.reset() function in POCO completion.

I could be missing something but probably should be emptied.

What should I do to solve the question?

As things are now, I'd add something like HTTPSession::clear() and modify HTTPClientSession::reset() function to:

Code: Select all

HTTPClientSession::reset(bool resetBuf = false)
{
  close();
  if (resetBuf) clear();
}

If you can test this on your case and submit a patch (or, even better, a github pull request) with unit test, we may be able to squeeze it in 1.5.1 later this week.

[kevin00000000ex]

So my question is why not emptied the _pBuffer through HTTPClientSession.reset() function in POCO completion.

I could be missing something but probably should be emptied.

What should I do to solve the question?

As things are now, I'd add something like HTTPSession::clear() and modify HTTPClientSession::reset() function to:

Code: Select all

HTTPClientSession::reset(bool resetBuf = false)
{
  close();
  if (resetBuf) clear();
}

If you can test this on your case and submit a patch (or, even better, a github pull request) with unit test, we may be able to squeeze it in 1.5.1 later this week.

My solution is similar with yours.To avoid unnecessary bug, I add a member function named release and clear buf in it.Now I'm testing it