Add-Ons & Services

Pull request process

General discussion regarding the development of POCO for contributors.
Posts: 11
Joined: 05 Mar 2013, 13:58

Pull request process

Postby cristiantm » 09 Mar 2014, 13:38

Not complaining, just really asking: is there any special reason why my two last pull requests (#384, #386) are not being merged while other new pull requests are? I see also there are some really old pull requests from other people without comments, not closed or merged

Just wondering If im missing something I should have done and have not noticed. If it is just time needed to review or something like that, just ignore this question, is fine and there is no hurry to get them approved. I just would like to know if I've missed something on the pull request submit process that could let the pull reuqest on a "limbo" forever.

Best regards,

Posts: 11
Joined: 05 Mar 2013, 13:58

Re: Pull request process

Postby cristiantm » 10 Mar 2014, 12:56

I see that they were merged :)...

So... was it just coincidence, or you like that we comment about the merge requests here too? The "How to contribute" page seems to be outdated, since it only refers to svn and send patches by mail...

Return to “Contributors”

Who is online

Users browsing this forum: No registered users and 1 guest