Adding an extra parameter to Process.launch

[vgimeno]

Hello:

What do yo thing about adding an extra parameter to Process.launch..., somthing like

Code: Select all


launchImpl(const std::string& command,
   const ArgsImpl& args,
   __const std::string& WOTKING_DIR__,
   Pipe* inPipe, Pipe* outPipe, Pipe* errPipe);   


any comments???

Thanks

[alex]

> any comments???

What's wrong with passing it in args?

[vgimeno]

at this time (v1.3.3) on windows implementation the

we have this code

BOOL rc = CreateProcessA(
NULL,
const_cast(commandLine.c_str()),
NULL,
NULL,
TRUE,
0,
NULL,
NULL, -----> lpCurrentDirectory
&startupInfo,
&processInfo
);


so I'm proposing pass this directory as an extra parameter on the launchImpl Method.

For the Unix implementation, it could be used calling chdir just before the call to exevp


Thanks

[guenter]

I have had this request from others as well, so I'll add it for the next release.