SecureStreamSocketImpl connectNB does not work

[eran]

This works:

std::string		buffer = "<?xml version='1.0'?><stream:stream xmlns:stream='http://etherx.jabber.org/streams' xmlns='jabber:client' to='gmail.com'>";

Poco::AutoPtr<Poco::Net::SecureStreamSocketImpl>	socket(new Poco::Net::SecureStreamSocketImpl);

try

{

	socket->connect(Poco::Net::SocketAddress("talk.google.com", 5223));



	Poco::Thread::sleep(1000);



	int	sent = socket->sendBytes(buffer.c_str(), int(buffer.size()));



	Poco::Thread::sleep(1000);



	char	buf[1024];

	int got = socket->receiveBytes(buf, 1023);



	Poco::Thread::sleep(1000);



	buffer = "<iq id='auth1' type='get' to='gmail.com'><query xmlns='jabber:iq:auth'><username>nouncer</username></query></iq>";

	sent = socket->sendBytes(buffer.c_str(), int(buffer.size()));



	Poco::Thread::sleep(1000);



	got = socket->receiveBytes(buf, 1023);



	Poco::Thread::sleep(1000);



}

catch (Poco::Exception& exc)

{

	std::cout << exc.displayText());

}

But changing to connectNB blows up. Any ideas?


EHL

[guenter]

I'll have Peter look into it.

Günter

[peter]

>
>
> But changing to connectNB blows up. Any ideas?

Well, if you do a connectNB followed by a 1 second sleep, and then a send,
you have no guarantee that the connection is already established
after the sleep.

Which error do you get back?

br
Peter
>
>
> EHL

[eran]

It asserts that the socket handle is already set. Nothing to do with the connection being ready.

EHL

[peter]

> It asserts that the socket handle is already set. Nothing to do with the connection being ready.
>
> EHL

Well,
I took your code and tested it on my machine.
It failed exactly once with an IOerror (maybe conincidence?),
but all subsequent tests worked (with connectNB) with the following change:

Change connectNB:

int tmpSocket=0;

BIO_get_fd(_pBIO,&tmpSocket);

poco_assert (-1 != tmpSocket);

setSockfd(tmpSocket);

establishTunnel();

connectSSL(address);

poco_check_ptr (_pSSL);

Remove the first 4 lines before establishTunnel.

br
Peter

[eran]

Thanks Peter,

I took a look and I am not sure what you mean by remove the 4 lines. Your code smaple includes them. If this is a bug fix, can you post the entire function after the change? If you cannot reporoduce it, I will email you the source files to try it out.

Thanks,

EHL

[peter]

Remove exactly those 4 lines from the function SecureStreamSocketImpl connectNB:

int tmpSocket=0;

BIO_get_fd(_pBIO,&tmpSocket);

poco_assert (-1 != tmpSocket);

setSockfd(tmpSocket);


br
Peter


> > It asserts that the socket handle is already set. Nothing to do with the connection being ready.
> >
> > EHL
>
> Well,
> I took your code and tested it on my machine.
> It failed exactly once with an IOerror (maybe conincidence?),
> but all subsequent tests worked (with connectNB) with the following change:
>
> Change connectNB:
>
> int tmpSocket=0;
>
> BIO_get_fd(_pBIO,&tmpSocket);
>
> poco_assert (-1 != tmpSocket);
>
> setSockfd(tmpSocket);
>
> establishTunnel();
>
> connectSSL(address);
>
> poco_check_ptr (_pSSL);
>
> Remove the first 4 lines before establishTunnel.
>
> br
> Peter
>
>

[eran]

Thanks!

Is this going to be an official solution in an upcoming release?

EHL

[peter]

> Thanks!
>
> Is this going to be an official solution in an upcoming release?
>
> EHL

Definitely,
thanks for informing us about this bug!

Peter