Zip::Decompress::decompressAllFiles()...

[dnebing]

I'd think this method should also restore the last modified timestamps...

Granted this is easy enough to do using the callback facility, but I'd expect decompressAllFiles() to restore everything it can and use the callback to make whatever adjustments I need to...

[dnebing]

I submitted a patch to do this to the poco@pocoproject.org email address.

[dnebing]

Here's the patch against 1.4.1:

Code: Select all

diff -crB Zip/src/Decompress.cpp ZipDecomp/src/Decompress.cpp
*** Zip/src/Decompress.cpp   2011-01-31 11:13:12.000000000 -0500
--- ZipDecomp/src/Decompress.cpp   2011-02-04 12:11:51.448119300 -0500
***************
*** 158,163 ****
--- 158,167 ----
           return false;
        }
 
+       // New file has been created, but we should restore the timestamp to make it match what was defined in the header
+       Poco::DateTime dt = hdr.lastModifiedAt();
+       file.setLastModified(dt.timestamp());
+       
        std::pair<const ZipLocalFileHeader, const Poco::Path> tmp = std::make_pair(hdr, file);
        EOk.notify(this, tmp);
     }


[dnebing]

Sorry, that line should read "aFile.setLastModified()" not "file.setLastModified()"... My bad